New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for case insensitive env names #313
Merged
samuelcolvin
merged 10 commits into
pydantic:master
from
jasonkuhrt:feat/277/base-settings-support-for-case-insensitive-env-names
Nov 26, 2018
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f4534a7
feat: add support for case insensitive env names
jasonkuhrt e82f3cc
feedback: just alias os.environ
jasonkuhrt 586d3fe
doc: update history
jasonkuhrt 4ba2117
doc: mention case_insensitive option
jasonkuhrt 7597961
refactor: feedback if-else expression assignment
jasonkuhrt a990fad
fix: formatting
jasonkuhrt 25a44c7
chore: encode black configuration in file to support IDEs
jasonkuhrt 6032ed9
docs: fix example
jasonkuhrt 5a7b709
feedback: no suppport for IDEs in this PR
jasonkuhrt 4f41cb4
feedback: style
jasonkuhrt File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
from pydantic import BaseSettings | ||
|
||
|
||
class Settings(BaseSettings): | ||
redis_host = 'localhost' | ||
|
||
class Config: | ||
case_insensitive = True |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came to the conclusion that
env_val
was a better ident name now that we haveenv_vars
above.env_var
in context ofenv_vars
sounds like its an item from the list. Buts its not. It is a value from the environ dict whileenv_vars
is said environ dict.If you prefer to not touch
env_var
ident name, I would suggest using a different name thanenv_vars
above. Maybenormalized_environ
?