support kw_only on dataclasses
#3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
DetachHead
force-pushed
the
master
branch
9 times, most recently
from
573d7a8
to
657d5ea
Compare
|
how do i make |
samuelcolvin
reviewed
Apr 2, 2022
There was a problem hiding this comment.
how do i make
plugin-fail.txtexpect a different output depending on the python version?
One solution (and it would make the overloads much cleaner below), is to always include kw_only in the type definition, then just raise a clear error for older versions?
Otherwise LGTM.
|
please update. |
DetachHead
force-pushed
the
master
branch
8 times, most recently
from
9a3c0e7
to
0c126e8
Compare
|
Is there any prediction for this feature? |
🔮I predict that it will be... BASED!!! |
|
Should go into v1.10 which I'll start working on after we get v1.9.1 out. |
DetachHead
force-pushed
the
master
branch
3 times, most recently
from
77bbc81
to
7b02df4
Compare
DetachHead
force-pushed
the
master
branch
2 times, most recently
from
dbdaa5f
to
9e9018e
Compare
samuelcolvin
approved these changes
Aug 8, 2022
|
Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
fix #3670 (it's a discussion tho because the issue template didn't let me raise a feature request)
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)