speedup __instancecheck__ check on BaseModel when they fail #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ntaylorwss
pushed a commit
to nicejobinc/pydantic
that referenced
this pull request
Jun 24, 2022
…#4081) * speedup __instancecheck__ check on BaseModel when they fail * add change description * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
abc
__isinstancecheck__can be very slow and eat a lot of memory, this seems to be particularly bad in the check returns False.We do this check a lot when generating schemas, often for types we can easily check are not Models.
Related issue number
FIx possibly for #3829, avoid performance depredation and memory growth in abc
__isinstancecheck__, see python/cpython#92810Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change