Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip directly to install FastAPI in its integration test #4282

Merged
merged 1 commit into from Aug 3, 2022
Merged

Use pip directly to install FastAPI in its integration test #4282

merged 1 commit into from Aug 3, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 26, 2022

Change Summary

This change results in:

  1. Slightly reduced CI time
  2. Allowance for FastAPI to use a different build backend if they wish. For example, moving away from Flit would introduce the possibility of using plugins that could source the version from Git, compile code with Mypyc, etc.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofek
Copy link
Contributor Author

ofek commented Jul 27, 2022

Oops I missed the last checklist item:

please review

@samuelcolvin samuelcolvin merged commit 338a70d into pydantic:master Aug 3, 2022
@samuelcolvin
Copy link
Member

thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants