fix main.BaseModel.(dict, json) fields types #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix main.BaseModel.dict fields (include, exclude, skip_defaults) types fix main.BaseModel.json fields (include, exclude, skip_defaults) types
|
please review |
hramezani
approved these changes
Jul 28, 2022
|
Thanks @shestakovich for the patch 👍 |
github-actions
bot
assigned shestakovich and unassigned hramezani, samuelcolvin and PrettyWood
fix types for BaseModel.copy fields: include, exclude, update BaseModel._iter fields: include, exclude
hramezani
approved these changes
Jul 28, 2022
|
please update. |
|
@samuelcolvin I think it's ready to merge. What are you waiting for here? |
|
Sorry, I hadn't seen the update, I'll review. please review. |
github-actions
bot
assigned hramezani, PrettyWood and samuelcolvin and unassigned shestakovich
|
thanks so much for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix main.BaseModel.dict fields (include, exclude, skip_defaults) types
fix main.BaseModel.json fields (include, exclude, skip_defaults) types
Change Summary
Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)