Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pattern matching version #4384

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

samuelcolvin
Copy link
Member

ref #3921 (comment)

skip change file check

@samuelcolvin
Copy link
Member Author

please review.

Copy link
Contributor

@Bobronium Bobronium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😸

@irgolic
Copy link
Contributor

irgolic commented Aug 16, 2022

Can't find a docs preview in CI, but conceptually LGTM

EDIT: Found it now that the rest of CI finished :) looks good

@samuelcolvin
Copy link
Member Author

Can't find a docs preview in CI, but conceptually LGTM

EDIT: Found it now that the rest of CI finished :) looks good

https://smokeshow.helpmanual.io/40174q1w4h6d071c084t/usage/models/#structural-pattern-matching

@samuelcolvin samuelcolvin merged commit 2f883b9 into master Aug 16, 2022
@samuelcolvin samuelcolvin deleted the fix-pattern-matching-version branch August 16, 2022 21:30
@Bobronium
Copy link
Contributor

We also might want to automate some basic checks for minimal required version in examples.

Is there a known tool for that guesses minimal required version by checking for new syntax/other features?

Or, we can just run docs-build in matrix. There will be warnings on lower versions, but shouldn't be any errors.

@samuelcolvin
Copy link
Member Author

Or, we can just run docs-build in matrix. There will be warnings on lower versions, but shouldn't be any errors.

makes sense, but let's wait for V2 when I want to change the docs to build like watchfiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants