Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to skip the change file check to pull request template #4428

merged 1 commit into from Aug 24, 2022


Copy link

Change Summary

skip change file check

Related issue number


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/ for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

samuelcolvin commented Aug 23, 2022

But if you add this to the pull request template, it'll be included in the pull request body by default. 🙃


  • Special regex to catch this in hooky
  • Keep it like this, but check manually (I'm not keen)
  • Have a link to instructions in the template
  • Omit the instructions, most people shouldn't need this

Copy link
Member Author

Ah 😄 🤦‍♂️ .

I've changed it and added a link to hooky.

Feel free to close the PR if you think it doesn't make sense at all

@samuelcolvin samuelcolvin merged commit 9420c2b into pydantic:main Aug 24, 2022
Copy link

Looks good, thanks.

It would be amazing if there was a way to render the PR advice in markdown, before creating a PR, but there doesn't seem to be a way.

@hramezani hramezani deleted the pull_request_template branch August 24, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants