-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move settings to pydantic-settings
#4492
Conversation
pydantic-settings
Unfortunately we have a slight problem - someone has already taken the package name |
otherwise should be ready. |
Do you have other options in your mind? |
He has replied and kindly agreed to release the name, he's just getting his 2fa reset. |
Great! According to the description of author's package
I reckon it'd be great to work together with author on the future of (official) |
Ye, I'd love him to contribute, he says he has no plans to continue to work on the package though. But maybe joining the team here will tempt him 😉. |
See https://github.com/pydantic/pydantic-settings, I've moved the existing logic to a new package. |
+1 for |
@samuelcolvin you probably already know this but better be safe than sorry: If the person does not reply or does not want to give you the package, you can try filling out a PEP 541 request here. |
Can we look into finally supporting this? 🙂 #1676 |
Yea definitely, V2 is an opportunity to fix all the messy stuff we couldn't fix in minor releases. |
@Ovsyanka83, relax, I'll transfer pypi name via my good will, and Samuel didn't sent me any blackmails ;) @PrettyWood , nice to hear that! If some of my original ideas could be integrated into new pydantic-settings, I'll gladly contribute @samuelcolvin , is there features of mine pydantic-settings library, which you would like to pull into new one? |
@danields761 I apologize :) I was writing this in case the package was name-squatted by someone. Thanks for transferring it! |
@danields761, thanks so much. Yes, I think so. Like @PrettyWood said, we definitely want to have better support for environment variables filling nested fields. I also think it would be really useful to provide details on where field are populated from as you mention. But I need to go through this in more depth and write a proposal, please keep your |
Oh, forgot to add @danields761, hapy to make you a collaborator on the |
@samuelcolvin , that would be nice, thanks! Please, let me know, when you'll be ready |
Thanks @danields761, I've sent you an email. |
FWIW, I have been using https://github.com/danields761/pydantic-settings/ mostly for its It greatly reduces the visual noise / clutter when documenting fields that otherwise do not even need a Hence, I would love to see this come upstream (not caring so much about the actual syntax / import). |
Thanks @hmeine, without looking into Could you create an issue on https://github.com/pydantic/pydantic-settings so we don't forget this. |
This could have made it possible to make libraries compatible with pydantic 1 and 2. Now we need to add the following requirement:
Which makes our libraries implicitly dependent on pydantic 2. If we could add See also #6497 |
Removing settings from pydantic as settings will be a separate package
pydantic-settings
.We might make it installable via
pydantic[settings]
, not sure yet if this is a good idea?skip change file check.