fix: avoid multiple calls of __post_init__ when dataclasses are inherited
#4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review |
16 tasks
samuelcolvin
approved these changes
Sep 7, 2022
|
@PrettyWood what do you think? Should we merge this and make a release, or do you want to have a shot at the other dataclass issues? |
|
I'll check this weekend. Can't before. Way too much on my plate sorry |
|
That's very kind, thank you. No problem about the delay. |
16 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
__post_init__was defined on a parent class,new_post_initwould be called many times because it "auto-refers" itself (it refers the parent one).Now we call the right
__post_init__fix #4487