-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move xfail from module to individual failing tests #4843
move xfail from module to individual failing tests #4843
Conversation
@samuelcolvin @hramezani I believe this PR is ready for review. All checks are passing, after I fixed a formatting/linting issue. Please let me know if you have any questions, feedback, or requests. |
Thanks @jimkring Thanks for your effort 👍 I can see there are some files that you marked all the tests as tests/test_validators_dataclass.py, and removed the global Other than this, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, this looks great to me.
Thank you so much for the contribution.
@samuelcolvin @hramezani is this PR ready for merge? I'm excited to brag to my friends and colleagues that I'm a contributor to Pydantic V2 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks so much for this @jimkring 🎉 I'd love you to contribute more to V2, a few suggestions:
|
As requested by @samuelcolvin here: #4835 (comment)