Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move xfail from module to individual failing tests #4843

Merged

Conversation

jimkring
Copy link
Contributor

As requested by @samuelcolvin here: #4835 (comment)

If you're interested in testing, one useful task would be to go through some of the test files with many tests passing but the entire module marked as xfail, remove the global xfail and mark just the tests which are actually failing as xfail. Let me know if you need more information.

@jimkring
Copy link
Contributor Author

jimkring commented Dec 14, 2022

@samuelcolvin @hramezani I believe this PR is ready for review. All checks are passing, after I fixed a formatting/linting issue. Please let me know if you have any questions, feedback, or requests.

@hramezani
Copy link
Member

Thanks @jimkring Thanks for your effort 👍

I can see there are some files that you marked all the tests as tests/test_validators_dataclass.py, and removed the global xfail. @samuelcolvin do you want to have these files (with all failing tests) like this?

Other than this, LGTM

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, this looks great to me.

Thank you so much for the contribution.

tests/test_create_model.py Outdated Show resolved Hide resolved
@jimkring
Copy link
Contributor Author

@samuelcolvin @hramezani is this PR ready for merge? I'm excited to brag to my friends and colleagues that I'm a contributor to Pydantic V2 :)

Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samuelcolvin samuelcolvin merged commit a96794d into pydantic:main Dec 21, 2022
@samuelcolvin
Copy link
Member

Thanks so much for this @jimkring 🎉

I'd love you to contribute more to V2, a few suggestions:

@jimkring jimkring deleted the move-pytest-mark-xfail-to-failing-tests branch December 21, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants