Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support assignment on DataclassProxy #4880

Merged
merged 1 commit into from Dec 28, 2022
Merged

fix: support assignment on DataclassProxy #4880

merged 1 commit into from Dec 28, 2022

Conversation

PrettyWood
Copy link
Member

closes #4695

@PrettyWood PrettyWood linked an issue Dec 27, 2022 that may be closed by this pull request
Available attributes are not found & side effects in pydantic.dataclasses.dataclass #4695
Closed
15 tasks
@PrettyWood
Copy link
Member Author

Please review

hramezani
hramezani approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samuelcolvin samuelcolvin merged commit c04923c into pydantic:1.10.X-fixes Dec 28, 2022
@samuelcolvin
Copy link
Member

awesome, thank you so much.

@PrettyWood PrettyWood deleted the dataclass-proxy-setattr branch December 28, 2022 18:26
@samuelcolvin samuelcolvin mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

@samuelcolvin samuelcolvin

@PrettyWood PrettyWood

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Available attributes are not found & side effects in pydantic.dataclasses.dataclass
3 participants
@PrettyWood @samuelcolvin @hramezani