Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work in progress: some tests passing for discriminated union #5000

Closed
wants to merge 1 commit into from

Conversation

philhchen
Copy link

NOTICE

We're currently in the process of rewriting pydantic in preparation for V2, see
https://pydantic-docs.helpmanual.io/blog/pydantic-v2/.

Please see https://github.com/orgs/pydantic/projects/1 for the major tasks required for this migration.

To avoid wasting your time, it would be best if you only created significant PRs related to that project.

Thank you for your interest in pydantic, and your patience. 🙏

Note: if you're making a pull request to fix pydantic v1.10, please make it against the 1.10.X-fixes branch.

@samuelcolvin
Copy link
Member

@adriangb @dmontagu please can you have a look at this.

@dmontagu
Copy link
Contributor

dmontagu commented Mar 9, 2023

I have something pretty similar in #5051 which I have already put in the effort to "merge" with generics on a branch I haven't opened a PR for yet; that said I will compare with this and make sure it doesn't handle anything I've missed in #5051 before closing this.

@dmontagu
Copy link
Contributor

dmontagu commented Mar 9, 2023

I believe everything in here is addressed in #5051 so I'm going to close this now.

@dmontagu dmontagu closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants