Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discriminated union support (v2) #5051

Merged
merged 18 commits into from
Mar 15, 2023
Merged

Add discriminated union support (v2) #5051

merged 18 commits into from
Mar 15, 2023

Commits on Mar 9, 2023

  1. Add support for discriminated unions

    @dmontagu
    dmontagu committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b708438 View commit details
    Browse the repository at this point in the history

  2. Fix issue with duplicate schemas in oneOf

    @dmontagu
    dmontagu committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    50d8377 View commit details
    Browse the repository at this point in the history

  3. Address TODOs

    @dmontagu
    dmontagu committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    10f48ce View commit details
    Browse the repository at this point in the history

  4. Remove print statement

    @dmontagu
    dmontagu committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c7557b4 View commit details
    Browse the repository at this point in the history

  5. Remove unwanted debug change

    @dmontagu
    dmontagu committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    94cd694 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Massively broken, but pushing as a checkpoint and reminder that this … 

    …still needs more work
    @dmontagu
    dmontagu committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    787d31f View commit details
    Browse the repository at this point in the history

  2. Rework discriminated union to use a class-based approach to better ha… 

    …ndle recursion
    @dmontagu
    dmontagu committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    b4a071a View commit details
    Browse the repository at this point in the history

  3. Fix 3.7 tests

    @dmontagu
    dmontagu committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1aa7083 View commit details
    Browse the repository at this point in the history

  4. Make Json/HashableJson private

    @dmontagu
    dmontagu committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    74898ee View commit details
    Browse the repository at this point in the history

  5. Add a docstring to the final method in _ApplyInferredDiscriminator

    @dmontagu
    dmontagu committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    b63c5a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Merge branch 'main' into v2-discriminated-union

    @dmontagu
    dmontagu committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b8a2eac View commit details
    Browse the repository at this point in the history

  2. Fix discriminated union test from test_forward_ref.py

    @dmontagu
    dmontagu committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a36d45c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Add test ensuring that literal enums produce valid JSON schema

    @dmontagu
    dmontagu committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    14e9b2f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into v2-discriminated-union

    @dmontagu
    dmontagu committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    77cac6e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Get to 100% code coverage

    @dmontagu
    dmontagu committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    29a0469 View commit details
    Browse the repository at this point in the history

  2. Improve comment

    @dmontagu
    dmontagu committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    1f624e8 View commit details
    Browse the repository at this point in the history

  3. Fix failing tests

    @dmontagu
    dmontagu committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    abcbe0d View commit details
    Browse the repository at this point in the history

  4. Convert __root__ tests to use Validator

    @dmontagu
    dmontagu committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    b36e2d6 View commit details
    Browse the repository at this point in the history