fix: V2 fix broken parametrized bases with GenericModels #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll make sure this gets in with #4970 |
|
I am pretty confident this is all handled now in #5125 (which I hope to merge today) but I will double check before closing this. |
|
There was one test in this PR that for some reason wasn't present in v1. Not sure if it was decided to remove it for some good reason there, but it was passing in v2 and I didn't see any good reason not to include it. So I added it to #5125 and will close this now, as I believe everything else from this PR is now in there. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #5052 but for V2.
Requires #4970