Allow serializers to ignore the info argument #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
commented
Mar 24, 2023
Comment on lines
-180
to
-191
| def test_invalid_signature_bad_wrap_signature() -> None: | ||
| with pytest.raises(TypeError, match='Invalid signature for wrap serializer'): | ||
|
|
||
| class _(BaseModel): | ||
| x: int | ||
|
|
||
| # note that type checkers won't pick this one up | ||
| # we could fix it but it would require some fiddling with the self argument in the | ||
| # callable protocols | ||
| @serializer('x', mode='wrap') | ||
| def no_args(self, value: Any, info: Any) -> Any: # pragma: no cover | ||
| ... |
There was a problem hiding this comment.
Note that we can't catch this at runtime or statically anymore because there's no way to distinguish it from (value, handler) unless we want to (1) introspect types or (2) force some of these to be keyword arguments (but then we have to construct kwargs in rust).
|
please review |
pydantic/_internal/_decorators.py
Outdated
| """ | ||
|
|
||
|
|
||
| def make_generic_v2_field_serializer( |
There was a problem hiding this comment.
don't think we need v2 in the name.
| ] | ||
|
|
||
|
|
||
| _VALID_SERIALIZER_SIGNATURES = """\ |
There was a problem hiding this comment.
find with this here for now, but it should end up in the docs.
pydantic/_internal/_decorators.py
Outdated
| ) | ||
| func = cast(AnyCoreSerializer, serializer) | ||
| return func | ||
| assert mode == 'wrap' |
There was a problem hiding this comment.
new line or else: would make this easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @samuelcolvin