Fix issue with unspecified generic type #554
Conversation
pydantic/validators.py
Outdated
| @@ -383,14 +383,16 @@ def find_validators(type_: AnyType, arbitrary_types_allowed: bool = False) -> Li | |||
|
|
|||
| for val_type, validators in _VALIDATORS: | |||
| try: | |||
| if issubclass(type_, val_type): | |||
| if lenient_issubclass(type_, val_type): | |||
There was a problem hiding this comment.
i think this isn't imported.
|
thanks for this, could you also fill out the checklist on the pull request template. |
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2457 2453 -4
Branches 488 488
=====================================
- Hits 2457 2453 -4 |
|
@samuelcolvin I updated the checklist, but I'm not sure if this fix merits any updates to the documentation. Let me know if you'd like me to add anything. |
tests/test_types.py
Outdated
|
|
||
| # This test passes -- should it fail, or is this the desired behavior? (It would make sense to me either way) | ||
| # It also passes if I replace Dict with Dict[int, int], so no new problems have been introduced. | ||
| assert Model(generic_list=[], generic_dict=[]) |
There was a problem hiding this comment.
This should definitely fail with the error as below.
However I've just check and it's already wrong on master so should be fixed separately. #558
|
@samuelcolvin The second to last commit implements the changes you asked for, and I think is basically ready for merging (after removing the bad test). However, I did look into preventing the empty list from passing dict validation. Ultimately, I think the question is whether you want to support converting iterables of pairs to dictionary. If so, we'd probably have to let it convert empty list to empty dict, or it would break whenever the list of pairs just happened to be empty. I'm happy to revert the current last commit on this branch and delete the mock test so this can be merged, and possibly start another issue separately, but I wanted to at least get your thoughts on the empty-list-to-dict validation issue before wrapping this up. (Would be easy to combine with this PR if desired.) |
|
@samuelcolvin I think it's ready to merge |
Seems to solve pydantic#550 With this change, models with bare `List` or `Dict` as a typehint still validate for type agreement, but don't validate the type of the parameters. I'm not sure this is the "right" fix (I don't know the implications of ignoring TypeVars like this), but considering how simple it was I figured I'd at least share.
Found this discussion: pydantic#545; `lenient_issubclass` does seem to fix it.
Hacky solution to prevent no validator exception. Maybe there's a better way?
|
Now rebased onto master |
|
thank a lot. |
* upstream/master: (138 commits) add 'none-any.whl' to pypi upload (pydantic#564) uprev update benchmarks (pydantic#563) cython (pydantic#548) Fix issue with unspecified generic type (pydantic#554) Run dataclass' original __post_init__ before validation (pydantic#560) try to stop annoying warnings in azure pipeline (pydantic#549) azure pipeline failOnStderr: false Azure Pipelines - tests for windows (pydantic#538) Fix JSON Schema for list, tuple, and set, improving interoperability (pydantic#540) uprev. Colors (pydantic#516) Fix to schema generation for IPv{4,6}{Address,Interface,Network} (pydantic#532) Fix __fields_set__ not using alias field names (pydantic#517) (pydantic#518) Change return type hint for create_model (pydantic#526) Tuple ellipsis (pydantic#512) Fix to schema generation for IPvAny{Address,Interface,Network} (pydantic#498) (pydantic#510) uprev Scheduled monthly dependency update for May (pydantic#499) Implement const keyword in Schema. (pydantic#469) ...
With this change, models with bare
ListorDictas a typehint still validate for type agreement, but don't validate the type of the parameters.Change Summary
Checks for TypeVar when looking up validators.
#550
Checklist
HISTORY.rsthas been updated#<number>@<whomever>