Error more eagerly for proper subclasses of generics that we don't know how to validate #5629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2264. (As it fixes some confusing behavior.)
We should go further and make similar changes for other subclasses of generics which don't have a "standard" way to call
__init__
.Users who want to support such classes should implement a
__get_pydantic_core_schema__
classmethod on the type in question, or if they don't control the type, on a pydantic-specific annotation used whenever that type occurs as a pydantic field annotation.An example of how to do this is included in
tests.test_edge_cases.test_custom_generic_validators
Selected Reviewer: @samuelcolvin