Respect config.alias_generator in pydantic dataclass #5673
Conversation
|
please review |
| validation_alias: str | list[str | int] | list[list[str | int]] | None = common_field['validation_alias'] | ||
| serialization_alias: str | None = common_field['serialization_alias'] | ||
| alias_generator = self.config_wrapper.alias_generator | ||
| if alias_generator: | ||
| validation_alias = alias_generator(name) | ||
| serialization_alias = alias_generator(name) | ||
|
|
There was a problem hiding this comment.
We can move this change into _common_field_schema but this function is used in _generate_td_field_schema as well. So, that's why I keep it in the _generate_dc_field_schema
There was a problem hiding this comment.
I think it may be a good idea to move into _common_field_schema since soon there will be something equivalent for _generate_model_field_schema (change coming down the pipe in pydantic core). Does it behave horribly/not work for typeddict if someone did add an alias? I think it's reasonable if someone might want to use camelCase aliases (specifically, via alias_generator) with typeddict too.
There was a problem hiding this comment.
I moved it to _common_field_schema and also added a test for typeddict inspired by your example.
hramezani
force-pushed
the
dataclass_alias_generator
branch
4 times, most recently
from
feca468
to
fc481e4
Compare
docs/usage/model_config.md
Outdated
| @@ -263,7 +263,7 @@ print(Character.model_json_schema(by_alias=True)) | |||
| { | |||
| 'type': 'object', | |||
| 'properties': { | |||
| 'ActorName': {'type': 'string', 'default': None, 'title': 'Actorname'}, | |||
| 'Name': {'type': 'string', 'default': None, 'title': 'Name'}, | |||
There was a problem hiding this comment.
I don't think this attribute name should be changed, because the alias generator isn't supposed to override explicitly-set aliases.
The relevant attribute is FieldInfo.alias_priority.
I think this shouldn't be too hard to fix, but we should look at how that is used now.
There was a problem hiding this comment.
I think we probably want to make a version of pydantic._internal._model_construction.apply_alias_generator for dataclasses / typeddict
hramezani
force-pushed
the
dataclass_alias_generator
branch
2 times, most recently
from
92a03d2
to
7be5b9e
Compare
|
please review |
hramezani
force-pushed
the
dataclass_alias_generator
branch
from
7be5b9e
to
f8ec612
Compare
Fixes #4286
Selected Reviewer: @Kludex