Add PastDatetime and FutureDatetime types #5720
Conversation
Deploying with
|
| Latest commit: |
9e88799
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b9c8cae7.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://future-past-datetime.pydantic-docs2.pages.dev |
|
Please review |
pydantic/types.py
Outdated
| return core_schema.datetime_schema(now_op='past') | ||
| else: | ||
| schema = handler(source) | ||
| assert schema['type'] == 'datetime' |
There was a problem hiding this comment.
What is the purpose of this assertion? If there's a chance it could be hit, it may be worth giving a clearer message of what is going wrong if it does get hit. (Same for FutureDatetime below)
There was a problem hiding this comment.
Actually I don't know how to hit this line. I just keep it because it was in the other types(AwareDatetime, FutureDate, ...).
@samuelcolvin Do you have any idea here?
There was a problem hiding this comment.
I guess the assert would fail if you use it as an annotation on something other than datetime.
If I'm wrong, we can remove, otherwise, yes a better error would be good.
There was a problem hiding this comment.
I've added a check that raises an error. added doc and test for error
docs/usage/types/datetime.md
Outdated
| @@ -23,6 +23,12 @@ types: | |||
| `FutureDate` | |||
| : like `date`, but the date should be in the future | |||
|
|
|||
| `PastDatetime` | |||
There was a problem hiding this comment.
surely we shouldn't have these documented in two places?
pydantic/types.py
Outdated
| return core_schema.datetime_schema(now_op='past') | ||
| else: | ||
| schema = handler(source) | ||
| assert schema['type'] == 'datetime' |
There was a problem hiding this comment.
I guess the assert would fail if you use it as an annotation on something other than datetime.
If I'm wrong, we can remove, otherwise, yes a better error would be good.
hramezani
force-pushed
the
future_past_datetime
branch
from
c0f9628
to
15f1549
Compare
hramezani
force-pushed
the
future_past_datetime
branch
from
15f1549
to
74b3b58
Compare
|
@samuelcolvin I've addressed all the comments. Please review |
Error documentation will come later with the validation error docs PR
Selected Reviewer: @samuelcolvin