Uprev pydantic-core to 0.31.0 #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
reviewed
May 10, 2023
dmontagu
reviewed
May 10, 2023
dmontagu
reviewed
May 10, 2023
adriangb
force-pushed
the
uprev-core-again
branch
from
ee2a972
to
4670f53
Compare
Deploying with
|
| Latest commit: |
5678bdc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad6a0df5.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://uprev-core-again.pydantic-docs2.pages.dev |
dmontagu
reviewed
May 10, 2023
| @@ -748,7 +746,7 @@ class ComputedFieldInfo: | |||
|
|
|||
| decorator_repr: typing.ClassVar[str] = '@computed_field' | |||
| wrapped_property: property | |||
| json_return_type: _core_schema.JsonReturnTypes | None | |||
| return_type: type[Any] | |||
There was a problem hiding this comment.
Is it okay that we use Any below but type[Any] here? I can understand why you might do this, but just want to make sure it was intentional.
There was a problem hiding this comment.
My reasoning was that type[Any] is technically incompatible if you try to assign int | str, but internally we pretty much want to treat it as a type, so type[Any] is more semantically meaningful
dmontagu
reviewed
May 10, 2023
dmontagu
reviewed
May 10, 2023
|
please review |
hramezani
approved these changes
May 10, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_instancevalidators w/json_or_pythonvalidatorsRequires pydantic/pydantic-core#598 and pydantic/pydantic-core#599
All tests passing locally, will mark as ready for review once we cut the core release
Selected Reviewer: @dmontagu