Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to errors and fields docstrings #5746

Merged
merged 3 commits into from
May 12, 2023
Merged

updates to errors and fields docstrings #5746

merged 3 commits into from
May 12, 2023

Conversation

tpdorsey
Copy link
Contributor

@tpdorsey tpdorsey commented May 11, 2023

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: efd284a
Status: ✅  Deploy successful!
Preview URL: https://6b02a5b5.pydantic-docs2.pages.dev
Branch Preview URL: https://edit-docstrings.pydantic-docs2.pages.dev

View logs

@tpdorsey
Copy link
Contributor Author

please review

pydantic/fields.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Only left one comment. Otherwise LGTM!

Please update

@tpdorsey
Copy link
Contributor Author

please review

pydantic/fields.py Outdated Show resolved Hide resolved
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one small suggestion.
Other than that, LGTM 👍

Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@tpdorsey tpdorsey merged commit 2c68e67 into main May 12, 2023
42 checks passed
@tpdorsey tpdorsey deleted the edit-docstrings branch May 12, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants