Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pydantic-settings test to CI #5758

Merged
merged 3 commits into from
May 16, 2023
Merged

Add pydantic-settings test to CI #5758

merged 3 commits into from
May 16, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented May 15, 2023 •
edited by pydantic-hooky bot

Needs this PR in pydantic-settings to be merged and a new release on pydantic-settings

Selected Reviewer: @samuelcolvin

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 15, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c12147f
Status: ✅  Deploy successful!
Preview URL: https://6260c3c6.pydantic-docs2.pages.dev
Branch Preview URL: https://test-pydantic-settings.pydantic-docs2.pages.dev

View logs

@hramezani hramezani force-pushed the test_pydantic_settings branch 6 times, most recently from bcdf951 to d4fd684 Compare May 15, 2023 10:51
samuelcolvin
samuelcolvin reviewed May 15, 2023
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
tests/test_pydantic_settings.sh Outdated Show resolved Hide resolved
@hramezani
Copy link
Member Author

All done, I think the CI will be green after we merged pydantic/pydantic-settings#58

@hramezani
Copy link
Member Author

please review

lig
lig suggested changes May 16, 2023
View reviewed changes
tests/test_pydantic_settings.sh Show resolved Hide resolved
tests/test_pydantic_settings.sh Outdated Show resolved Hide resolved
@pydantic-hooky pydantic-hooky bot assigned hramezani and unassigned samuelcolvin May 16, 2023
lig
lig suggested changes May 16, 2023
View reviewed changes
tests/test_pydantic_settings.sh Outdated Show resolved Hide resolved
tests/test_pydantic_settings.sh Outdated Show resolved Hide resolved
@hramezani
Copy link
Member Author

please review

@pydantic-hooky pydantic-hooky bot assigned samuelcolvin and unassigned hramezani May 16, 2023
lig
lig approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@samuelcolvin samuelcolvin merged commit a0d6cc4 into main May 16, 2023
43 checks passed
@samuelcolvin samuelcolvin deleted the test_pydantic_settings branch May 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

@lig lig lig approved these changes

Assignees

@samuelcolvin samuelcolvin

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hramezani @lig @samuelcolvin