🔥 Remove _base_class_defined hack in favor of an empty bases check
#5761
Conversation
|
please review |
|
I'll just note this may be in tension with some of the goals of #5740 — simplifying the MRO etc. I like getting rid of the hacky check for subclass of BaseModel, but I don't have a strong opinion about what's best here (or whether there might be other unintended consequences, especially for performance). Happy to defer to @adriangb or @samuelcolvin |
I think, it would be even better. I'm happy to remove |
pydantic/main.py
Outdated
| # track of whether we've created the `BaseModel` class yet, and therefore whether it's safe to refer to it. If | ||
| # it *hasn't* been created, we assume that the `__new__` call we're in the middle of is for the `BaseModel` | ||
| # class, since that's defined immediately after the metaclass. | ||
| if bases == (_BaseModelBase,): |
There was a problem hiding this comment.
can we change this to if bases != ... and then revert most of these changes here?
There was a problem hiding this comment.
I've minimized the changeset.
IMO, it would be nice to have
if condition:
# a couple of lines for a special case
return
# a lot of lines for the main body
return
instead of
if condition:
# a lot of lines for the main body
return
else:
# a couple of lines for a special case
return
lig
force-pushed
the
burn-base-class-defined-hack
branch
from
53eeb5b
to
1c5b48f
Compare
Deploying with
|
| Latest commit: |
8dfc06c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72936651.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://burn-base-class-defined-hack.pydantic-docs2.pages.dev |
lig
force-pushed
the
burn-base-class-defined-hack
branch
from
1c5b48f
to
f814d6b
Compare
lig
changed the title
_base_class_defined hack in favor of a marker base class_base_class_defined hack in favor of an empty bases check
lig
force-pushed
the
burn-base-class-defined-hack
branch
from
f814d6b
to
afde015
Compare
lig
force-pushed
the
burn-base-class-defined-hack
branch
from
afde015
to
c109adb
Compare
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Change Summary
Remove
_base_class_definedhack and check for emptybasesas an indicator for detectingBaseModelinModelMetaclass. These classes are no longer tied to their places in the module.Related issue number
None
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
Selected Reviewer: @adriangb