Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy edits for validation errors #5777

Merged
merged 2 commits into from
May 17, 2023
Merged

Copy edits for validation errors #5777

merged 2 commits into from
May 17, 2023

Conversation

tpdorsey
Copy link
Contributor

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 16, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 200db4a
Status: ✅  Deploy successful!
Preview URL: https://21f307c2.pydantic-docs2.pages.dev
Branch Preview URL: https://doc-validation-errors.pydantic-docs2.pages.dev

View logs

dmontagu
dmontagu requested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update

@tpdorsey @dmontagu
Apply suggestions from code review
200db4a 
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
@dmontagu dmontagu merged commit 2f4ced7 into main May 17, 2023
43 checks passed
@dmontagu dmontagu deleted the doc-validation-errors branch May 17, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@tpdorsey tpdorsey

Labels
awaiting author revision documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpdorsey @dmontagu