Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a signature for __init_subclass__ to typecheck class kwargs #5791

Merged
merged 1 commit into from
May 18, 2023

Conversation

dmontagu
Copy link
Contributor

Closes #5430

The Unpack[ConfigDict] thing works with pyright/vscode but not mypy (..yet). But there is a PEP for it that has been accepted for 3.12.

@dmontagu dmontagu requested a review from adriangb May 18, 2023 14:13
@dmontagu dmontagu merged commit 261b62b into main May 18, 2023
43 checks passed
@dmontagu dmontagu deleted the init-subclass-signature branch May 18, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type annotations for class Model(BaseModel, extra=...)
2 participants