-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typechecking, docs, and minor bugs with Field/FieldInfo #5800
Conversation
Deploying with Cloudflare Pages
|
please review |
This adds a change that breaks pydantic-settings. I have opened a PR that will fix that in pydantic/pydantic-settings#59. I will disable CI for pydantic settings here for now then we can reenable once everything is back in sync. |
Not sure why cloudflare pages is failing but that's the only problem now. (Because I disabled the run of pydantic-settings. We could re-enable once it is updated to use this version of pydantic.) Perhaps related to it needing to clone pydantic-settings for the docs..? For context, the reason pydantic-settings is incompatible with this branch is because I changed FieldInfo from storing the pre-processed (And as noted above, I have already opened a PR on pydantic-settings that will fix its compatibility with pydantic.) |
Going to try reopening to see if that resolves the cloudflare build issue.. |
Hmm nope couldn't get it to work. @samuelcolvin I guess I need some info about the cloudflare thing |
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@dmontagu Why do we need to add |
Selected Reviewer: @lig