Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise documentation landing page #5835

Merged
merged 4 commits into from
May 24, 2023
Merged

Revise documentation landing page #5835

merged 4 commits into from
May 24, 2023

Conversation

tpdorsey
Copy link
Contributor

@tpdorsey tpdorsey commented May 23, 2023

Reworked rationale (why pydantic?), features, and examples.

List of companies using pydantic has been expanded as a simple two-column list.

Turning this into logos will be a separate PR.

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@tpdorsey
Copy link
Contributor Author

please review

docs/index.md Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

CF page problem got fixed at 5e81582. You need to rebase.
please update

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e3138c
Status: ✅  Deploy successful!
Preview URL: https://50e28640.pydantic-docs2.pages.dev
Branch Preview URL: https://doc-landing.pydantic-docs2.pages.dev

View logs

@tpdorsey
Copy link
Contributor Author

please review

Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tpdorsey tpdorsey merged commit 3ffb0c4 into main May 24, 2023
43 checks passed
@tpdorsey tpdorsey deleted the doc-landing branch May 24, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants