Feat/serialize import string #5841

ybressler · 2023-05-24T02:03:43Z

Change Summary

Add default serialization to ImportString + add tests for coverage. (Need more edge cases, but for now, is good enough.)

Unit tests for the changes exist
Tests pass on CI and coverage remains at 100%
Documentation reflects the changes where applicable
changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

samuelcolvin

also windows tests are failing, I'll try to fix this not to include it in V2.

pydantic/types.py

ybressler added 3 commits May 23, 2023 21:18

Introduce serialization functionality + modify tests pydantic#4958

99b1a68

Add additional tests for import string pydantic#4958

1e1dc84

remove unnecessary test case

89e1398

samuelcolvin reviewed May 28, 2023

View reviewed changes

pydantic/types.py Outdated Show resolved Hide resolved

samuelcolvin changed the title ~~Feat/serialize import string #4958~~ Feat/serialize import string May 28, 2023

move method, cleanup call, fix tests

e02eb79

samuelcolvin approved these changes May 28, 2023

View reviewed changes

samuelcolvin marked this pull request as ready for review May 28, 2023 12:33

samuelcolvin added 2 commits May 28, 2023 13:35

cleanup tests

b7a0851

bump

ac6f98e

samuelcolvin enabled auto-merge (squash) May 28, 2023 13:12

samuelcolvin approved these changes May 28, 2023

View reviewed changes

samuelcolvin merged commit e2c2121 into pydantic:main May 28, 2023
49 checks passed

ybressler deleted the feat/serialize_import_string_#4958 branch May 29, 2023 15:02