Handle validators on vanilla dataclass fields #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f329cf7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://834e957a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://v2-dataclass-improvements.pydantic-docs2.pages.dev |
|
@adriangb If you are totally against this change we can leave it, but if you'd just want to see other tests pass first, I'm open to any suggestions. |
adriangb
approved these changes
May 24, 2023
|
If you feel confident that this doesn't break under edge cases then let's go for it |
|
I wouldn't say confident, but it seems sound to me. I'll give a bit more thorough review of where we construct schemas related to dataclasses before merging. @adriangb there's nothing similar with TypedDict now is there? I think we can't do decorators on those (in not-small-part related to inability to inspect class hierarchy), just making sure though. |
|
It should work for TypedDict on the latest typing-extensions version and Python 3.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5271.
Still need to add a test or two, but opening the PR now so work doesn't end up duplicated.
See #5271 (comment) for at least one test we can add.