Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo grid for pydantic users #5880

Merged
merged 5 commits into from
May 30, 2023
Merged

Logo grid for pydantic users #5880

merged 5 commits into from
May 30, 2023

Conversation

tpdorsey
Copy link
Contributor

@tpdorsey tpdorsey commented May 26, 2023

Replaces the bullet list of companies using pydantic with a grid of logos.

TODO:

  • expand the grid with more logos!
  • improve dark mode rendering

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c1301a1
Status: ✅  Deploy successful!
Preview URL: https://9d8bab63.pydantic-docs2.pages.dev
Branch Preview URL: https://doc-company-grid.pydantic-docs2.pages.dev

View logs

@tpdorsey
Copy link
Contributor Author

please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lets:

  • remove the section of bullet points above this
  • add FastAPI and Jupyter to the list of logos

@samuelcolvin
Copy link
Member

please update.

@samuelcolvin
Copy link
Member

I think long term, the logos should get smaller, and we should have more of them, but that can happen later.

@tpdorsey
Copy link
Contributor Author

please review

@samuelcolvin
Copy link
Member

Screenshot 2023-05-26 at 22 41 26

Some logos aren't showing, also some don't show well in dark mode - I guess we can just change those colors to black.

We'll need to make each logo into a link in future, but for now, can we just set the title on each image to the company name?

Please update.

@tpdorsey
Copy link
Contributor Author

@samuelcolvin what do we want them to link to? I think the logos are fine unless we have some CTA at the other end of the link

@samuelcolvin
Copy link
Member

I think we need a page (doesn't need to be in a menu) with heading for each of these companies, and one sentence on how we know they're using pydantic and how they're using us.

Also need to add:

  • nasa
  • nvidia
  • IPCC - international panel on climate change
  • JP Morgan
  • Twitter

@tpdorsey
Copy link
Contributor Author

please review

@tpdorsey
Copy link
Contributor Author

I will add the links and supplemental information about each logo as a separate pr

@samuelcolvin samuelcolvin enabled auto-merge (squash) May 30, 2023 17:06
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you.

@samuelcolvin samuelcolvin merged commit e44bba2 into main May 30, 2023
53 checks passed
@samuelcolvin samuelcolvin deleted the doc-company-grid branch May 30, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants