Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix botched merge, cleanup unused code #5888

Merged
merged 1 commit into from
May 26, 2023
Merged

Fix botched merge, cleanup unused code #5888

merged 1 commit into from
May 26, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented May 26, 2023

Selected Reviewer: @lig

@adriangb
Copy link
Member Author

please review

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3dfdac3
Status: ✅  Deploy successful!
Preview URL: https://0038301f.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-merge.pydantic-docs2.pages.dev

View logs

@adriangb adriangb enabled auto-merge (squash) May 26, 2023 17:25
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code, fewer bugs 👍🏻

@adriangb adriangb merged commit a046545 into main May 26, 2023
50 of 52 checks passed
@adriangb adriangb deleted the fix-merge branch May 26, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants