Fix @model_validator on nested models
#5889
Conversation
|
|
Deploying with
|
| Latest commit: |
32a1b9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://940fecf5.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-bug-nested-model-validat.pydantic-docs2.pages.dev |
adriangb
force-pushed
the
fix-bug-nested-model-validator
branch
from
0f73ca7
to
32ee89c
Compare
|
please review |
| @@ -181,7 +181,7 @@ def model_serializer( | |||
| *, | |||
| mode: Literal['plain', 'wrap'] = 'plain', | |||
| json_return_type: _core_schema.JsonReturnTypes | None = None, | |||
| ) -> Callable[[Any], _decorators.PydanticDescriptorProxy[Any]] | _decorators.PydanticDescriptorProxy[Any]: | |||
| ) -> Callable[[Any], Any]: | |||
There was a problem hiding this comment.
Is it a problem that the non-callable return type was removed here? I mean, I'm guessing it's not a problem, but it would it be more careful in some way? Happy to leave like this if preferable just want to make sure it wasn't an oversight.
There was a problem hiding this comment.
I just pushed a slightly better version. We can get even more granular (e.g. defining a couple of Protocols like we do form some of the other validators/serializers) but I don't want to do that in this PR, I'm only changing it because it was causing issues with the test I'm adding here.
There was a problem hiding this comment.
pls can we add (if we don't already have) an example of both @model_validator and @model_validator(...) in mypy tests please.
| @@ -181,7 +181,7 @@ def model_serializer( | |||
| *, | |||
| mode: Literal['plain', 'wrap'] = 'plain', | |||
| json_return_type: _core_schema.JsonReturnTypes | None = None, | |||
| ) -> Callable[[Any], _decorators.PydanticDescriptorProxy[Any]] | _decorators.PydanticDescriptorProxy[Any]: | |||
| ) -> Callable[[Any], Any]: | |||
There was a problem hiding this comment.
pls can we add (if we don't already have) an example of both @model_validator and @model_validator(...) in mypy tests please.
dmontagu
dismissed
samuelcolvin’s stale review
Added @model_validator to mypy test module
Fixes #5790
Selected Reviewer: @Kludex