Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挌 Move email tests to "tests with deps" job #5904

Merged
merged 1 commit into from
May 28, 2023
Merged

馃挌 Move email tests to "tests with deps" job #5904

merged 1 commit into from
May 28, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented May 27, 2023 •
edited by pydantic-hooky bot

Change Summary

We need to run tests on CI with and without email dependency group installed. This allows combining both runs into cumulative coverage report.

Related issue number

None

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@lig
Copy link
Contributor Author

lig commented May 27, 2023

At the moment of writing this comment main has 94.63% coverage and this PR has 94.68%.

@lig lig marked this pull request as ready for review May 27, 2023 21:32
@lig
Copy link
Contributor Author

lig commented May 27, 2023

please review

@samuelcolvin samuelcolvin enabled auto-merge (squash) May 28, 2023 12:11
samuelcolvin
samuelcolvin approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you.

@samuelcolvin samuelcolvin merged commit f72ec71 into main May 28, 2023
53 checks passed
@samuelcolvin samuelcolvin deleted the improve-combining-coverage-on-ci branch May 28, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lig @samuelcolvin @dmontagu