Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide __pydantic_*__ from @dataclass_transform #5923

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

dmontagu
Copy link
Contributor

I believe @tiangolo can confirm this behaves correctly.

@dmontagu dmontagu requested a review from adriangb May 29, 2023 15:56
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b287397
Status: ✅  Deploy successful!
Preview URL: https://c7fa47a2.pydantic-docs2.pages.dev
Branch Preview URL: https://hide-dunder-pydantics.pydantic-docs2.pages.dev

View logs

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I confirm that this works. 🚀

I pulled this branch, re-compiled/installed, confirmed it works, then checked out main again to confirm it is needed.

I also ran a model script to make sure it was running (although tests would catch that as well).

@dmontagu dmontagu merged commit c63adc7 into main May 30, 2023
53 checks passed
@dmontagu dmontagu deleted the hide-dunder-pydantics branch May 30, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants