Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow passing config to TypeAdapter for models and implement config for TypedDict #5939

Merged
merged 5 commits into from
May 30, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented May 30, 2023

Requires pydantic-core update.

cc @samuelcolvin

Selected Reviewer: @Kludex

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM. Please update.

docs/usage/errors.md Outdated Show resolved Hide resolved
docs/usage/errors.md Outdated Show resolved Hide resolved
docs/usage/errors.md Outdated Show resolved Hide resolved
pydantic/_internal/_generate_schema.py Outdated Show resolved Hide resolved
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec728b6
Status: ✅  Deploy successful!
Preview URL: https://4ef84c45.pydantic-docs2.pages.dev
Branch Preview URL: https://update-tests.pydantic-docs2.pages.dev

View logs

adriangb and others added 5 commits May 30, 2023 11:49
Co-authored-by: Samuel Colvin <s@muelcolvin.com>
Co-authored-by: Samuel Colvin <s@muelcolvin.com>
@adriangb adriangb marked this pull request as ready for review May 30, 2023 16:49
@adriangb
Copy link
Member Author

please review

@samuelcolvin
Copy link
Member

merging to fix in #5942

@samuelcolvin samuelcolvin merged commit dee4978 into main May 30, 2023
13 of 52 checks passed
@samuelcolvin samuelcolvin deleted the update-tests branch May 30, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants