✅ More RootModel tests
#5943
Merged
✅ More RootModel tests
#5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c8be7a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7cab1e3.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://more-root-model.pydantic-docs2.pages.dev |
lig
force-pushed
the
more-root-model
branch
5 times, most recently
from
8f10588
to
a8186f0
Compare
|
please review |
Kludex
reviewed
May 31, 2023
Comment on lines
+254
to
+256
| # TODO: Should this be an `AttributeError`? | ||
| with pytest.raises(ValueError, match='other_attr'): | ||
| m.other_attr = 10 |
There was a problem hiding this comment.
It shouldn't be ValueError, but not sure if it should be something different than AttributeError.
There was a problem hiding this comment.
In vanilla Python it's AttributeError.
>>> class A:
... __slots__ = ()
...
>>> a = A()
>>> a.foo = 42
Traceback (most recent call last):
Cell In[10], line 1
a.foo = 42
AttributeError: 'A' object has no attribute 'foo'There was a problem hiding this comment.
Are you going to use AttributeError on this PR then?
There was a problem hiding this comment.
Not in this one. Maybe later. That is why I did put TODO here:)
|
please update |
|
@Kludex please review |
Kludex
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add tests illustrating
RootModelissuesRelated issue number
None
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
Selected Reviewer: @samuelcolvin