🐛 Fix aliases priority #6023
🐛 Fix aliases priority #6023
Conversation
Deploying with
|
| Latest commit: |
f148284
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b10b3bdc.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-alias-priority.pydantic-docs2.pages.dev |
tests/test_aliases.py
Outdated
| @@ -238,6 +238,62 @@ class Child(Parent): | |||
| assert [f.serialization_alias for f in Child.model_fields.values()] == ['w_ser_alias', 'X', 'Y', 'Z'] | |||
|
|
|||
|
|
|||
| def test_aliases_priority(): | |||
There was a problem hiding this comment.
Can we break these into separate tests? I don't like redefining the type multiple times in the same test, I got super confused for a minute because I looked halfway down after seeing the definition at the top before I realized the type was getting redefined in each block
There was a problem hiding this comment.
(Also would be annoying to debug if something breaks some of these cases and not others, as it will fail out on the first one rather than letting you see precisely which ones fail.)
There was a problem hiding this comment.
Could also use pytest.mark.parametrize but no need if it's hard to structure the code in a parametric way — I think it's fine to just have a handful of similar-but-different tests if that's easier.
There was a problem hiding this comment.
I didn't want to parametrize, but this case it didn't look that bad... 👀
tests/test_aliases.py
Outdated
| class Model(BaseModel, alias_generator=str.upper): | ||
| x: int = Field(..., serialization_alias='x1') | ||
|
|
||
| # validation_alias should take priority over alias_generator |
There was a problem hiding this comment.
| # validation_alias should take priority over alias_generator | |
| # serialization_alias should take priority over alias_generator |
I believe this is a copy-paste error
Change Summary
Fix aliases priority.
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)