Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update docstings on networks.py #6069

Merged
merged 2 commits into from Jun 9, 2023
Merged

📝 Update docstings on networks.py #6069

merged 2 commits into from Jun 9, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jun 9, 2023

CLOSES DOC-16

Selected Reviewer: @hramezani

@Kludex Kludex requested a review from hramezani June 9, 2023 11:25
@Kludex
Copy link
Member Author

Kludex commented Jun 9, 2023

please review

@linear
Copy link

linear bot commented Jun 9, 2023

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d95998
Status: ✅  Deploy successful!
Preview URL: https://42066728.pydantic-docs2.pages.dev
Branch Preview URL: https://docs-networks-module.pydantic-docs2.pages.dev

View logs

@Kludex Kludex requested a review from lig June 9, 2023 11:30
Copy link
Contributor

@tpdorsey tpdorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggested edits. Looks good.

pydantic/networks.py Outdated Show resolved Hide resolved
pydantic/networks.py Outdated Show resolved Hide resolved
pydantic/networks.py Outdated Show resolved Hide resolved
pydantic/networks.py Outdated Show resolved Hide resolved
Co-authored-by: Terrence Dorsey <terrend@mishu.com>
@Kludex Kludex enabled auto-merge (squash) June 9, 2023 11:42
@Kludex Kludex merged commit 459b6c6 into main Jun 9, 2023
50 checks passed
@Kludex Kludex deleted the docs/networks-module branch June 9, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants