Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated-kwargs with removed-kwargs #6107

Merged
merged 1 commit into from Jun 13, 2023
Merged

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jun 13, 2023

W‍‍e use deprecated-kwargs error code for removed kwargs. So, it's better to replace it with removed-kwargs.
Right now, there is no usecase for deprecated-kwargs error code but we can add it again in the future if we need it.

Selected Reviewer: @samuelcolvin`

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec4c88e
Status: ✅  Deploy successful!
Preview URL: https://d129c95c.pydantic-docs2.pages.dev
Branch Preview URL: https://removed-kwargs.pydantic-docs2.pages.dev

View logs

@hramezani
Copy link
Member Author

please review

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, can you link the issue/describe why this is needed?

@hramezani
Copy link
Member Author

For the record, can you link the issue/describe why this is needed?

There is no issue for this. So, I've updated the PR description.

@hramezani hramezani merged commit 5d23836 into main Jun 13, 2023
53 checks passed
@hramezani hramezani deleted the removed-kwargs branch June 13, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants