Improve the regex used for NameEmail validation #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2955
While I agree it would be better to move the logic to rust as suggested in #2955 (comment), in the interest of fixing this for users, I would suggest we just make this change now.
Happy to add more test cases, special callout to @henrybetts for doing the research and putting together an improved regex ages ago. I took an approach inspired by #2955 (comment), and just cleaned up the regex a bit (and used a function to build it to get a bit better implicit documentation), and the tests all seem to be passing now as desired.
If anyone wants more tests cases let me know, but I think this covers the ones called out explicitly in the issue.
Selected Reviewer: @Kludex