New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting type for values in __pydantic_extra__
#6139
Conversation
Deploying with Cloudflare Pages
|
626531d
to
80b28c1
Compare
Looks like there's some weirdness with the typing evaluation but I'll wait to fix that until I get some initial feedback on the proposal as a whole. |
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe suggest adding some docs before merging this as it's kind of a weird thing to document, would be nice to get the docs added as part of the feature. But ... approved ...
b11ea8f
to
883a766
Compare
Selected Reviewer: @dmontagu