Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting type for values in __pydantic_extra__ #6139

Merged
merged 3 commits into from Jun 15, 2023
Merged

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Jun 14, 2023

Selected Reviewer: @dmontagu

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d6f00b
Status: ✅  Deploy successful!
Preview URL: https://e41e3c61.pydantic-docs2.pages.dev
Branch Preview URL: https://extra-validator.pydantic-docs2.pages.dev

View logs

@adriangb adriangb marked this pull request as ready for review June 14, 2023 16:12
@adriangb
Copy link
Member Author

Looks like there's some weirdness with the typing evaluation but I'll wait to fix that until I get some initial feedback on the proposal as a whole.

@adriangb
Copy link
Member Author

please review

Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe suggest adding some docs before merging this as it's kind of a weird thing to document, would be nice to get the docs added as part of the feature. But ... approved ...

@adriangb adriangb enabled auto-merge (squash) June 15, 2023 22:42
@adriangb adriangb merged commit 34881de into main Jun 15, 2023
50 checks passed
@adriangb adriangb deleted the extra-validator branch June 15, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants