Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Try reproducing rebuilding recursive schema with a ForwardRef #6159

Merged
merged 1 commit into from Jun 16, 2023
Merged

✅ Try reproducing rebuilding recursive schema with a ForwardRef #6159

merged 1 commit into from Jun 16, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented Jun 15, 2023 •
edited

Change Summary

A test added in attempt to reproduce the corresponding issue

Related issue number

Fix #5730

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@lig lig mentioned this pull request Jun 15, 2023
Closed
1 task
@dmontagu dmontagu marked this pull request as ready for review June 16, 2023 18:26
@dmontagu dmontagu merged commit beff646 into main Jun 16, 2023
53 checks passed
@dmontagu dmontagu deleted the 5730-keyerror-during-model_rebuildrecursive-schemas branch June 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError during model_rebuild/recursive schemas
2 participants
@lig @dmontagu