Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Decimal in python to avoid precision loss #6321

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Jun 30, 2023

Fixes #6295

Selected Reviewer: @lig

@adriangb
Copy link
Member Author

please review

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1fd070a
Status: ✅  Deploy successful!
Preview URL: https://3c92acc4.pydantic-docs2.pages.dev
Branch Preview URL: https://decimal-precision.pydantic-docs2.pages.dev

View logs

@adriangb
Copy link
Member Author

Quick benchmark vs main:

image
image

So a bit of a slowdown, but not super significant.

Copy link
Contributor

@lig lig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@adriangb adriangb merged commit 5487182 into main Jun 30, 2023
50 checks passed
@adriangb adriangb deleted the decimal-precision branch June 30, 2023 17:59
@san595
Copy link

san595 commented Jul 4, 2023

632

@adriangb
Copy link
Member Author

adriangb commented Jul 5, 2023

632

?

@san595
Copy link

san595 commented Jul 5, 2023

#6321 (comment)

1 similar comment
@san595
Copy link

san595 commented Jul 5, 2023

#6321 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decimal Deserialization Doesn't Maintain Accuracy
3 participants