Fix validate_call schema generation and doc error for TypedDict
#6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
893e2db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://08763d2a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-doc-error-description.pydantic-docs2.pages.dev |
adriangb
changed the title
|
please review |
Kludex
requested changes
Jul 2, 2023
|
About the confusion that I did on the version being 3.11: there's a comment on the standard library that I believe is not correct about this - this is a comment to remind me to check this when I get home. |
|
I'm sure we need |
adriangb
changed the title
validate_call schema generation and doc error for TypedDict
|
@Kludex added a test and fixes some other bugs with |
|
please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6356
Selected Reviewer: @lig