Allow combining Field annotations by merging them
#6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
dbe22e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7169334a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://merge-field.pydantic-docs2.pages.dev |
|
@tiangolo I think this solves the problem you raised in #6336 (comment) |
adriangb
commented
Jul 3, 2023
Comment on lines
+1236
to
+1237
| if field_infos: | ||
| annotations = [*non_field_infos, FieldInfo.merge_field_infos(*field_infos)] |
There was a problem hiding this comment.
This re-ordering does have some possible consequences. In particular, each FieldInfo currently hooks into __get_pydantic_core_schema__ on its own so the order matters. But this re-ordering says "even if everything else runs in the order it is put into Annotated, we do special handling for Field() so that it runs at the end".
|
please review |
|
Yesss! This solves it for me, and simplifies the code on FastAPI as I can now just use the If this goes in (and is released), I'll be able to make the final FastAPI beta, and then the final release in one or two days. 🚀 |
hramezani
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6353, closes #6336
Selected Reviewer: @hramezani