New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pickling of RootModel #6457
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under impression that I've tested that :(
Overall LGTM 👍🏻
A module for the test is up to you.
tests/test_construction.py
Outdated
@@ -353,6 +353,18 @@ class PickleModelTwo(BaseModel): | |||
assert not hasattr(m3, '_foo_') | |||
|
|||
|
|||
def test_pickle_root_model(create_module): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to keep consolidating RootModel
tests in tests/test_root_model.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving it there while I add a changefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick fix! 🚀
Closes #6455