Fix the un-hashability of various annotation types, for use in caching generic containers

[dmontagu]

skip change file check

Selected Reviewer: @hramezani

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	fee40b4
Status:	✅  Deploy successful!
Preview URL:	https://02e16799.pydantic-docs2.pages.dev
Branch Preview URL:	https://fix-unhashable-annotations.pydantic-docs2.pages.dev

View logs

[dmontagu]

Hmm thought about this a bit more and I think it might be better to not add TransformSchema to __all__ quite yet. I want to play with other possible tweaks to these annotations before merging this.

[ybressler]

Note: I'm trying to get in the habit of reviewing more code here. Apologies if my comments are n00b.

Code looks straightforward overall. I appreciate the addition of tests. Your PR description mentions inclusion of methods in caching, though I don't see any tests which relate to the caching of these methods. (Unless they are implicit?)

[ybressler]

Transformation from a string repr of an int/float/decimal is no longer automatically executed in V2, right? I'm assuming you are overriding this with TransformSchema(lambda _s: core_schema.int_schema())?

Also, this test could be rewritten as parameterized if you wanted to go overboard. Perhaps some other edge cases like negative numbers, or floats? (Though would a float get transformed to an int?)

[dmontagu]

Your PR description mentions inclusion of methods in caching, though I don't see any tests which relate to the caching of these methods. (Unless they are implicit?)

Optional[X] attempts to cache the result of Optional.__getitem__(X), and fails if X is not hashable. So the addition of Optional[SkipValidation[int]] etc. is how I am testing this. Note these tests do fail without the changes in this PR.

[dmontagu]

please review