⬆ Upgrade pydantic-core to v2.2.0
#6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4b46299
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://747cce96.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://lig-upgrade-pydantic-core-to-fnz7.pydantic-docs2.pages.dev |
lig
commented
Jul 11, 2023
| actual_errors = exc_info.value.errors(include_url=False) | ||
| if expected_errors != actual_errors: | ||
| pytest.fail(f'Actual errors: {actual_errors}\nExpected errors: {expected_errors}') | ||
| _assert_eq( |
There was a problem hiding this comment.
It looks like diff shows + for the right part but pytest uses + for the left part in assert left == right. Thus, this is reversed to match pytest.
| @@ -233,6 +233,7 @@ def test_error_codes(): | |||
| assert code_error_codes == documented_error_codes, 'Error codes in code and docs do not match' | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason='`enum` is not documented') | |||
There was a problem hiding this comment.
pydantic-core has introduced enum error type in pydantic/pydantic-core#751
lig
force-pushed
the
lig/upgrade-pydantic-core-to-2-2-0
branch
from
0fd3b42
to
4b46299
Compare
|
please review |
adriangb
approved these changes
Jul 11, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Update
pydantic-core, rebuildpdm.lock, fix tests.Related issue number
None
Checklist
Closes #6588
Selected Reviewer: @adriangb