Fix incorrect subclass check for secretstr #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVndnblcke
force-pushed
the
fix-incorrect-subclass-check-for-secretstr
branch
from
5cdbfca
to
04be64b
Compare
Currently subclasses of SecretStr fail to evaluate `self.field_type is SecretStr` and default to `bytes_type`. This is not how it should go as the subclass explicitly subclasses the SecretStr type. This fix tests if the type is of SecretStr with `issubclass` which states: > A class is considered a subclass of itself Which makes is backwards compatible for the actual SecretStr as well.
AlexVndnblcke
force-pushed
the
fix-incorrect-subclass-check-for-secretstr
branch
from
04be64b
to
c6a25ad
Compare
|
please review |
davidhewitt
approved these changes
Jul 18, 2023
Kludex
pushed a commit
to Kludex/pydantic
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently subclasses of SecretStr fail to evaluate
self.field_type is SecretStrand default tobytes_type. This is not how it should go as the subclass explicitly subclasses the SecretStr type.This fix tests if the type is of SecretStr with
issubclasswhich states:Which makes is backwards compatible for the actual SecretStr as well.
Change Summary
Allow pydantic scheme creation to work with subclasses of
SecretStrRelated issue number
fix #6729
Checklist
Selected Reviewer: @davidhewitt