Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pydantic-core to 2.4.0 #6831

Merged
merged 3 commits into from Jul 24, 2023
Merged

update pydantic-core to 2.4.0 #6831

merged 3 commits into from Jul 24, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Updates pydantic-core to 2.4.0.

I've cherry-picked the commit from #6711 by @JeanArhancet to implement the new UUID support (many thanks).

Related issue number

N/A

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10b72a0
Status: ✅  Deploy successful!
Preview URL: https://9416c92c.pydantic-docs2.pages.dev
Branch Preview URL: https://dh-core-2-4.pydantic-docs2.pages.dev

View logs

schema = core_schema.lax_or_strict_schema(
lax_schema=lax,
strict_schema=strict,
schema = core_schema.uuid_schema(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the InnerSchemaValidator here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelcolvin samuelcolvin merged commit 55e0985 into main Jul 24, 2023
48 checks passed
@samuelcolvin samuelcolvin deleted the dh/core-2.4 branch July 24, 2023 19:31
@JeanArhancet JeanArhancet mentioned this pull request Jul 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants